RFR: 8324649: Shenandoah: refactor implementation of free set [v4]

Kelvin Nilsen kdnilsen at openjdk.org
Tue Jan 30 23:39:49 UTC 2024


On Sun, 28 Jan 2024 22:57:09 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix typo in comment
>>  - Remove unnecessary include
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 43:
> 
>> 41: 
>> 42: private:
>> 43:   size_t _max;                  // The maximum number of heap regions
> 
> Is this a constant or can it change with the number of regions in the whole heap (and therefore as the heap expands and contracts), or is it a fixed constant depending on the maximum size of the heap (and the fixed region size)?

Thanks.  I'm declaring as const.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1472117031


More information about the hotspot-gc-dev mailing list