RFR: 8324649: Shenandoah: refactor implementation of free set [v4]

Kelvin Nilsen kdnilsen at openjdk.org
Wed Jan 31 00:56:02 UTC 2024


On Mon, 29 Jan 2024 00:03:12 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix typo in comment
>>  - Remove unnecessary include
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 413:
> 
>> 411:   //
>> 412:   // Free set maintains mutator and collector views, and normally they allocate in their views only,
>> 413:   // unless we special cases for stealing and mixed allocations.
> 
> I'd drop this comment, unless such special cases actually exist in the code today. Do they?

Thanks for calling this out.  I've refined these comments to reflect current reality.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1472175977


More information about the hotspot-gc-dev mailing list