RFR: 8324649: Shenandoah: refactor implementation of free set [v4]
Kelvin Nilsen
kdnilsen at openjdk.org
Wed Jan 31 01:02:02 UTC 2024
On Mon, 29 Jan 2024 00:15:05 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Fix typo in comment
>> - Remove unnecessary include
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 443:
>
>> 441: // GCLABs are for evacuation so we must be in evacuation phase. If this allocation is successful, increment
>> 442: // the relevant evac_expended rather than used value.
>> 443:
>
> This seems like a leakage of abstraction to me. Besides, I do not see `evac_expended` anywhere in this file?
Removing mention of evac_expended. That comment is vestigial.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1472181750
More information about the hotspot-gc-dev
mailing list