RFR: 8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled [v3]
Wang Zhuo
wzhuo at openjdk.org
Wed Jan 31 11:15:16 UTC 2024
On Wed, 31 Jan 2024 10:18:08 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Wang Zhuo has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update test, adding some error message.
>
> test/hotspot/jtreg/gc/parallel/TestAlwaysPreTouchBehavior.java line 92:
>
>> 90: } else {
>> 91: System.out.println("Passed RSS = " + rss + " committed memory " + committedMemory);
>> 92: }
>
> Why these branches/print here? Could these println be incorporated in the assert msg below?
These printing are not necessary. Information are moved to the assertion message.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17610#discussion_r1472672751
More information about the hotspot-gc-dev
mailing list