RFR: 8324649: Shenandoah: refactor implementation of free set [v4]

[Kelvin Nilsen]

On Mon, 29 Jan 2024 22:59:24 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix typo in comment
>>  - Remove unnecessary include
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 58:
> 
>> 56: 
>> 57:   inline void shrink_bounds_if_touched(ShenandoahFreeMemoryType set, size_t idx);
>> 58:   inline void expand_bounds_maybe(ShenandoahFreeMemoryType set, size_t idx, size_t capacity);
> 
> To my comment elsewhere of the meaning of `_if_touched` (for the shrink), couldn't you just say `_maybe` like you did for the expand?
> 
> I personally (subjectively) prefer `interval`, but `bounds` is fine if there is precedence elsewhere in the code.

I'll change to shrink_interval_if_boundary_modified and expand_interval_if_boundary_modified.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1472906053