RFR: 8325053: Serial: Move Generation::save_used_region to TenuredGeneration [v2]

Stefan Karlsson stefank at openjdk.org
Wed Jan 31 15:13:04 UTC 2024


On Wed, 31 Jan 2024 14:31:15 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Trivial moving a field and its accessors from superclass to subclass.
>
> Albert Mingkun Yang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   s1-save-used-region

Changes requested by stefank (Reviewer).

src/hotspot/share/gc/serial/tenuredGeneration.hpp line 50:

> 48:   MemRegion _prev_used_region;
> 49: 
> 50: protected:

Some of the GC classes put all variables under a protected section instead of a private section. We just haven't cleaned that up. This means that you should probably stick with the current style to put the variables in the protected section, or better yet, just remove the "protected:" line and let all variables be private.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17654#pullrequestreview-1853983420
PR Review Comment: https://git.openjdk.org/jdk/pull/17654#discussion_r1472969083


More information about the hotspot-gc-dev mailing list