RFR: 8335147: Serial: Refactor TenuredGeneration::promote [v2]

Thomas Schatzl tschatzl at openjdk.org
Tue Jul 2 07:59:23 UTC 2024


On Thu, 27 Jun 2024 13:11:38 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Trivial extracting "copying" logic from old-gen-allocation method to unify the use of `Copy` and `transform_stack_chunk` in young-gc promotion path.
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into s1-alloc-promote
>  - s1-alloc-promote

Changes requested by tschatzl (Reviewer).

src/hotspot/share/gc/serial/tenuredGeneration.hpp line 171:

> 169:   // The "obj_size" argument is just obj->size(), passed along so the caller can
> 170:   // avoid repeating the virtual call to retrieve it.
> 171:   oop allocate_for_promotion(oop obj, size_t obj_size);

The first paragraph above needs to be adjusted to the new decreased functionality.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19899#pullrequestreview-2152994303
PR Review Comment: https://git.openjdk.org/jdk/pull/19899#discussion_r1662021141


More information about the hotspot-gc-dev mailing list