RFR: 8335493: ClearedAllSoftRefs::~ClearedAllSoftRefs should reset SoftRefPolicy::_should_clear_all_soft_refs

Albert Mingkun Yang ayang at openjdk.org
Tue Jul 2 09:17:17 UTC 2024


On Tue, 2 Jul 2024 08:57:12 GMT, Liang Mao <lmao at openjdk.org> wrote:

> set_should_clear_all_soft_refs will be set to true adaptively but never reset to false.

I see; does it make sense to reset to false inside `check_gc_overhead_limit` so that callers of `set_should_clear_all_soft_refs` are in the same scope? (Other callers of `set_should_clear_all_soft_refs` always invokes it in pairs.)

If this reset-to-false occurs in the destructor as in your PR, who sets it to true for Parallel or other GCs?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19982#issuecomment-2202460902


More information about the hotspot-gc-dev mailing list