RFR: 8335395: G1: Verification does not detect references into Free regions [v2]
Thomas Schatzl
tschatzl at openjdk.org
Wed Jul 3 07:47:28 UTC 2024
> Hi all,
>
> please review this improvement to `G1CollectedHeap::is_obj_dead()` where references into free regions were inadvertedly considered as live. This makes verification not fail with a proper error message when encountering references to objects in free regions (it may still fail for other reasons).
>
> The alternative would have been fixing this in verification code only, but that method does not seem that hot, and the additional code not too slow either, but feel free to tell me otherwise and have me move the check.
>
> This has been verified by @christianhaeubl who reported the issue.
>
> Testing: gha
>
> Thanks,
> Thomas
Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
ayang review
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/19983/files
- new: https://git.openjdk.org/jdk/pull/19983/files/8106008b..020a2c3c
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=19983&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=19983&range=00-01
Stats: 7 lines in 2 files changed: 3 ins; 2 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/19983.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19983/head:pull/19983
PR: https://git.openjdk.org/jdk/pull/19983
More information about the hotspot-gc-dev
mailing list