RFR: 8335395: G1: Verification does not detect references into Free regions [v2]
Ivan Walulya
iwalulya at openjdk.org
Wed Jul 3 08:51:18 UTC 2024
On Wed, 3 Jul 2024 07:47:28 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hi all,
>>
>> please review this improvement to `G1CollectedHeap::is_obj_dead()` where references into free regions were inadvertedly considered as live. This makes verification not fail with a proper error message when encountering references to objects in free regions (it may still fail for other reasons).
>>
>> The alternative would have been fixing this in verification code only, but that method does not seem that hot, and the additional code not too slow either, but feel free to tell me otherwise and have me move the check.
>>
>> This has been verified by @christianhaeubl who reported the issue.
>>
>> Testing: gha
>>
>> Thanks,
>> Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>
> ayang review
Marked as reviewed by iwalulya (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/19983#pullrequestreview-2155850772
More information about the hotspot-gc-dev
mailing list