Integrated: 8335395: G1: Verification does not detect references into Free regions

Thomas Schatzl tschatzl at openjdk.org
Wed Jul 3 16:32:28 UTC 2024


On Tue, 2 Jul 2024 08:14:44 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this improvement to `G1CollectedHeap::is_obj_dead()` where references into free regions were inadvertedly considered as live. This makes verification not fail with a proper error message when encountering references to objects in free regions (it may still fail for other reasons).
> 
> The alternative would have been fixing this in verification code only, but that method does not seem that hot, and the additional code not too slow either, but feel free to tell me otherwise and have me move the check.
> 
> This has been verified by @christianhaeubl who reported the issue.
> 
> Testing: gha
> 
> Thanks,
>   Thomas

This pull request has now been integrated.

Changeset: 9a91865f
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/9a91865ff38f6fbb48b9aba5028e0b529d9bce76
Stats:     5 lines in 2 files changed: 4 ins; 0 del; 1 mod

8335395: G1: Verification does not detect references into Free regions

Reviewed-by: ayang, iwalulya

-------------

PR: https://git.openjdk.org/jdk/pull/19983


More information about the hotspot-gc-dev mailing list