RFR: 8334513: New test gc/TestAlwaysPreTouchBehavior.java is failing [v2]

[Thomas Stuefe]

On Mon, 1 Jul 2024 13:02:09 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>>> Why the explicit -Xmx64m? As I understand this is essentially the launcher, whose heap-size is of little importance.
>> 
>> No particular reason, just don't like launchers to use large heaps. I can remove it.
>> 
>>> Also, why does the launch require WhiteBoxAPI?
>> 
>> Because the launcher needs to access hostAvailableMemory in order to decide before starting the test whether it makes sense to start the test.
>
>> just don't like launchers to use large heaps.
> 
> Could you add a comment at the start of this file explaining the test setup, launcher creating another VM + real test flags? There, the rational for small heap (64M) can be covered as well.
> 
> Some text on these fields can also help understand this test.
> 
>     final static long expectedMaxNonHeapRSS = M * 256;
>     final static  long requiredAvailableBefore = heapsize * 2 + expectedMaxNonHeapRSS;
>     final static  long requiredAvailableDuring = expectedMaxNonHeapRSS;

Sure.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19803#discussion_r1665258517