RFR: 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs [v2]

Denghui Dong ddong at openjdk.org
Fri Jul 5 08:46:24 UTC 2024


On Fri, 5 Jul 2024 08:33:41 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Liang Mao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reset in check_gc_overhead_limit
>
> At a quick glance it looks okay, but I've not looked at it carefully enough to say I've reviewed it.  Given the amount of
> discussion I can't agree with it being "trivial".  Small, yes, but with potentially significant impact.  And HotSpot rules
> around trivial changes and bypassing some of the review process requires agreement by the Reviewer, of which
> there is none recorded in the discussion here.

@kimbarrett 

Sorry about that. I overlooked the rule that hotspot non-trivial changes require reviews from at least two reviewers.
I'll be more careful in the future to follow the rules strictly.


-------------

PR Comment: https://git.openjdk.org/jdk/pull/19982#issuecomment-2210458600


More information about the hotspot-gc-dev mailing list