RFR: 8331411: Shenandoah: Reconsider spinning duration in ShenandoahLock [v7]
Xiaolong Peng
xpeng at openjdk.org
Mon Jul 8 14:34:38 UTC 2024
On Mon, 8 Jul 2024 11:01:51 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahLock.cpp line 47:
>>
>>> 45: void ShenandoahLock::contended_lock_internal(JavaThread* java_thread) {
>>> 46: assert(!ALLOW_BLOCK || java_thread != nullptr, "Must have a Java thread when allowing block.");
>>> 47: // Spin this much on multi-processor, do not spin on multi-processor.
>>
>>>do not spin on multi-processor
>>
>> Did you mean on **single**-processor?
>
> Yes, I think so. @pengxiaolong, please do a simple follow-up fix?
Thanks, I'll fix it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19570#discussion_r1668758318
More information about the hotspot-gc-dev
mailing list