RFR: 8336378: Parallel: Rename allocate to expand_and_allocate in PSOldGen

Ivan Walulya iwalulya at openjdk.org
Mon Jul 15 09:44:52 UTC 2024


On Mon, 15 Jul 2024 09:32:20 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Trivial renaming a method.

Changes requested by iwalulya (Reviewer).

src/hotspot/share/gc/parallel/psOldGen.hpp line 124:

> 122:     HeapWord* res;
> 123:     do {
> 124:       res = cas_allocate_noexpand(word_size);

seems incorrect that we can allocate without expanding, yet the method name is "expand_and_allocate". Or you write a bit more about the motivation behind this renaming.

-------------

PR Review: https://git.openjdk.org/jdk/pull/20181#pullrequestreview-2177277893
PR Review Comment: https://git.openjdk.org/jdk/pull/20181#discussion_r1677564774


More information about the hotspot-gc-dev mailing list