RFR: 8335925: Serial: Move allocation API from Generation to subclasses [v2]
Ivan Walulya
iwalulya at openjdk.org
Tue Jul 23 11:55:34 UTC 2024
On Mon, 15 Jul 2024 12:32:14 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Trivial moving methods from parent class to subclasses. The unused second arg is also removed along the way. The API names are descriptive enough so that the accompanying comments are dropped as well.
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - review
> - Merge branch 'master' into s1-gen-alloc
> - s1-gen-alloc
Would have been very helpful to explain why it was ok to move these out of the base class.
-------------
Marked as reviewed by iwalulya (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20084#pullrequestreview-2193763548
More information about the hotspot-gc-dev
mailing list