RFR: 8336098: G1: Refactor G1RebuildRSAndScrubTask [v2]

[Guoxiong Li]

On Mon, 22 Jul 2024 19:38:47 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Small refactoring to consolidate the early-return logic during scan-and-rebuild.
>> 
>> Test: tie1-3
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into g1-conc-rebuild
>  - review
>  - g1-conc-rebuild

Please note several logs are removed in this patch. I am OK with such removal, considering that the logs are at trace level.

One nit below.

src/hotspot/share/gc/g1/g1ConcurrentRebuildAndScrub.cpp line 102:

> 100:     // Yield if enough has been processed; returns if the concurrent marking cycle
> 101:     // has been aborted for any reason.
> 102:     bool yield_if_necessary(G1HeapRegion* hr) {

The previous method `yield_if_necessary()` (the one without parameter) can be removed.

-------------

Changes requested by gli (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20114#pullrequestreview-2193441057
PR Review Comment: https://git.openjdk.org/jdk/pull/20114#discussion_r1687726015