Integrated: 8336912: G1: Undefined behavior for G1ConfidencePercent=0

Thomas Schatzl tschatzl at openjdk.org
Wed Jul 31 08:10:36 UTC 2024


On Mon, 29 Jul 2024 09:11:16 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hello,
> 
>   please review this change to workaround an unintentional division by zero found by ubsan.
> 
> The global option `G1ConfidencePercent` allowed zero as confidence for predictions which this change simply disallows: not sure what the response of the VM would be if the user told it that it should have absolutely no confidence (i.e. confidence is zero) in the predictions (not "very low" confidence).
> 
> Testing: after this change, the ubsan failure goes away.
> 
> Thanks,
>   Thomas

This pull request has now been integrated.

Changeset: de0b5040
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/de0b50400a4155554c83d5c3346ab1ec5353df61
Stats:     6 lines in 2 files changed: 0 ins; 0 del; 6 mod

8336912: G1: Undefined behavior for G1ConfidencePercent=0

Reviewed-by: ayang, sangheki

-------------

PR: https://git.openjdk.org/jdk/pull/20371


More information about the hotspot-gc-dev mailing list