RFR: 8333486: Parallel: Remove unused methods in psParallelCompact [v2]

Albert Mingkun Yang ayang at openjdk.org
Tue Jun 4 11:26:21 UTC 2024


On Tue, 4 Jun 2024 11:05:55 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/gc/parallel/psParallelCompact.hpp line 193:
> 
>> 191:   void set_start_array(ObjectStartArray* s) { _start_array = s; }
>> 192: 
>> 193: private:
> 
> Given that in this class (`SpaceInfo`) the existing spacing for visibility specifiers uses a space in front I would keep it that way (or change all of them). Mixing them within a single class seems just too strange, but it's your call in the end.

Removed all preceding space.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19539#discussion_r1625825506


More information about the hotspot-gc-dev mailing list