RFR: 8331675: gtest CollectorPolicy.young_min_ergo_vm fails after 8272364

Albert Mingkun Yang ayang at openjdk.org
Mon Jun 10 09:58:34 UTC 2024


Remove a gtest test case around `NewSize`.

The gtest `young_min_ergo` essentially checks NewSize 20M set ergonomically will be preserved and MinNewSize will be <= 20M. However, the GCArguments::initialize_heap_sizes can overwrite the 20M value, in the process of respecting `InitialHeapSize` and `NewRatio`.

A more correct assert would be `ASSERT_LE(MinNewSize, NewSize);` in `CheckYoungMin` so that the up-to-date `NewSize` is picked up. The `MinNewSize <= NewSize` invariant is already checked in `GenArguments::assert_size_info`, so this gtest offers little benefit.

-------------

Commit messages:
 - gtest-remove

Changes: https://git.openjdk.org/jdk/pull/19621/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19621&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8331675
  Stats: 12 lines in 1 file changed: 0 ins; 12 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/19621.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19621/head:pull/19621

PR: https://git.openjdk.org/jdk/pull/19621


More information about the hotspot-gc-dev mailing list