Integrated: 8331675: gtest CollectorPolicy.young_min_ergo_vm fails after 8272364
Albert Mingkun Yang
ayang at openjdk.org
Tue Jun 11 06:59:20 UTC 2024
On Mon, 10 Jun 2024 09:53:02 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> Remove a gtest test case around `NewSize`.
>
> The gtest `young_min_ergo` essentially checks NewSize 20M set ergonomically will be preserved and MinNewSize will be <= 20M. However, the GCArguments::initialize_heap_sizes can overwrite the 20M value, in the process of respecting `InitialHeapSize` and `NewRatio`.
>
> A more correct assert would be `ASSERT_LE(MinNewSize, NewSize);` in `CheckYoungMin` so that the up-to-date `NewSize` is picked up. The `MinNewSize <= NewSize` invariant is already checked in `GenArguments::assert_size_info`, so this gtest offers little benefit.
This pull request has now been integrated.
Changeset: badf1cb9
Author: Albert Mingkun Yang <ayang at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/badf1cb9ce9dcae6cca92046f7cc1231067ca799
Stats: 12 lines in 1 file changed: 0 ins; 12 del; 0 mod
8331675: gtest CollectorPolicy.young_min_ergo_vm fails after 8272364
Reviewed-by: tschatzl, zgu, gli
-------------
PR: https://git.openjdk.org/jdk/pull/19621
More information about the hotspot-gc-dev
mailing list