RFR: 8333925: Shenandoah: Heuristics should have an option to ignore abbreviated cycles [v2]

[William Kemper]

On Tue, 11 Jun 2024 19:52:23 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename option to ShenandoahAdaptiveIgnoreAbbreviated, remove unnecessary Amazon copyright from header
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.cpp line 3:
> 
>> 1: /*
>> 2:  * Copyright (c) 2018, 2020, Red Hat, Inc. All rights reserved.
>> 3:  * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
> 
> Remove?

Okay.

> src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp line 152:
> 
>> 150:           range(0,1.0)                                                      \
>> 151:                                                                             \
>> 152:   product(bool, ShenandoahAdaptiveIgnoreShortCycles, true, EXPERIMENTAL,    \
> 
> Abbreviated instead of Short,for consistency with use of terms in code?

Good idea.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19640#discussion_r1635555954
PR Review Comment: https://git.openjdk.org/jdk/pull/19640#discussion_r1635556040