RFR: 8333786: Serial: Remove SerialHeap::_incremental_collection_failed [v3]

[Thomas Schatzl]

On Wed, 12 Jun 2024 15:14:30 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Removing logic around incremental-collection failure. Additionally, the decision to use from-space if `!collection_attempt_is_safe() && !_eden_space->is_empty()` can cause heap too full to be handled properly by full-gc, so the support alloc-in-from-space is also removed.
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   s1-alloc

> too full to be handled properly by full-gc,

What does "the heap can be too full to be handled properly by full-gc" mean? Does full gc crash? Or does it simply not complete (and go OOME anyway)? Is the condition wrong?

Can you describe the case, the current behavior and the new behavior in more detail?

>  so the support alloc-in-from-space is also removed.

Is this really required? Why remove functionality and not fix?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19594#issuecomment-2167843721