RFR: 8333962: Obsolete OldSize [v2]

Albert Mingkun Yang ayang at openjdk.org
Sat Jun 15 08:54:14 UTC 2024


On Sat, 15 Jun 2024 05:09:49 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   obsolete-old-size
>
> src/hotspot/share/runtime/arguments.cpp line 37:
> 
>> 35: #include "gc/shared/gcArguments.hpp"
>> 36: #include "gc/shared/gcConfig.hpp"
>> 37: #include "gc/shared/genArguments.hpp"
> 
> Why is this needed?

`Arguments::set_heap_size` accesses `OldSize`, which is declared in this header.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19647#discussion_r1640921256


More information about the hotspot-gc-dev mailing list