RFR: 8333962: Obsolete OldSize [v2]

Albert Mingkun Yang ayang at openjdk.org
Mon Jun 17 14:14:13 UTC 2024


On Mon, 17 Jun 2024 13:25:00 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   obsolete-old-size
>
> src/hotspot/share/gc/shared/genArguments.hpp line 36:
> 
>> 34: extern size_t MaxOldSize;
>> 35: 
>> 36: extern size_t OldSize;
> 
> Any reason we still want to keep `OldSize` variable? becase GCs really care about are `init`, `min` and `max` values.

The concept of "initial old-gen size" will always be there. If `OldSize` is removed, all readers need to be updated to `InitialHeapSize - NewSize`. It's not obvious that is definitely better/more readable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19647#discussion_r1642885640


More information about the hotspot-gc-dev mailing list