RFR: 8333769: Pretouching tests dont test pretouching [v2]

Sonia Zaldana Calles szaldana at openjdk.org
Mon Jun 17 15:38:30 UTC 2024


On Sat, 15 Jun 2024 07:55:16 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Changes based on feedback and also adding test for serial collector
>
> test/hotspot/jtreg/gc/TestAlwaysPreTouchBehavior.java line 108:
> 
>> 106:     }
>> 107:     Runtime runtime = Runtime.getRuntime();
>> 108:     long committedMemory = runtime.totalMemory() / 1024; // in kb
> 
> Why divide by KB? Seems off.

Ah yes, this is an oversight on my part. The old test converted to KB as the RSS read from `/proc/pid/status` reported KB. I had already added this conversion in the linux specific implementation of `os::rss`, so I'll go ahead and remove this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19699#discussion_r1643008407


More information about the hotspot-gc-dev mailing list