RFR: 8334060: Implementation of Late Barrier Expansion for G1

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Tue Jun 18 10:22:13 UTC 2024


On Tue, 18 Jun 2024 02:46:08 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> Consider using lea instructions and ExternalAddress to generate relocation:

Just for my understanding, do you mean that the comment immediately above (introduced in [JDK-8028109](https://bugs.openjdk.org/browse/JDK-8028109)):

// Do not use ExternalAddress to load 'byte_map_base', since 'byte_map_base' is NOT
// a valid address and therefore is not properly handled by the relocation code.

 does not hold anymore in mainline?

> The same in generate_c1_post_barrier_runtime_stub()

Note that this JEP is not concerned with C1 barriers, in fact `generate_c1_post_barrier_runtime_stub()` is not touched by the changeset.

> Leyden needs relocation for card table base.

For ease of reviewing, porting, etc. I would suggest to introduce the required changes for project Leyden as a follow-up RFE, would that work?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19746#discussion_r1644210103


More information about the hotspot-gc-dev mailing list