RFR: 8334060: Implementation of Late Barrier Expansion for G1 [v2]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Thu Jun 20 04:17:30 UTC 2024
On Wed, 19 Jun 2024 08:56:27 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> Yes.
>>
>> Two nits: add `can_` to those two bools and unpack the final return expr, sth like:
>>
>>
>> int barriers = 0;
>>
>> if (!can_remove_pre...) {
>> barriers |= pre;
>> }
>> if (!can_remove_post...) {
>> barriers |= post;
>> }
>>
>> return barriers;
>
> Thanks, I will do some testing before merging.
Done (commit d722d4c7c1534794aaa38d54ecf7a4c12b158e84).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19746#discussion_r1646903037
More information about the hotspot-gc-dev
mailing list