RFR: 8334147: Shenandoah: Avoid taking lock for disabled free set logging [v8]

Xiaolong Peng xpeng at openjdk.org
Thu Jun 27 20:55:51 UTC 2024


On Thu, 27 Jun 2024 20:43:50 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Xiaolong Peng has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Accidentally removed a empty line
>>  - Method renaming
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 1139:
> 
>> 1137:       DEBUG_ONLY(|| LogTarget(Debug, gc, free)::is_enabled())) {
>> 1138:     ShenandoahHeapLocker locker(_heap->lock());
>> 1139:     log_status();
> 
> If you do the changes, fix up the indenting here as well. I think one space is missing here in 2-space indent.

I thinks is the line 1140 having indent issue, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19915#discussion_r1657803880


More information about the hotspot-gc-dev mailing list