RFR: 8334147: Shenandoah: Avoid taking lock for disabled free set logging [v9]

[Xiaolong Peng]

On Thu, 27 Jun 2024 20:47:53 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Xiaolong Peng has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - typo
>>  - Fix indenting
>>  - Add one line comments for log_status and log_status_under_lock
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 343:
> 
>> 341: 
>> 342:   void recycle_trash();
>> 343:   // log status, assuming lock has alredy been acquired by the caller.
> 
> "already". Also see previous comment about removing enablement check in `log_status` and asserting. Will then need to check other callers and retest.

We should keep it, finish_rebuild also call log_status since it already holds the lock, removing  enablement check will affect the log behavior in finish_rebuild.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19915#discussion_r1657809001