RFR: 8334147: Shenandoah: Avoid taking lock for disabled free set logging [v8]

Xiaolong Peng xpeng at openjdk.org
Thu Jun 27 22:58:20 UTC 2024


On Thu, 27 Jun 2024 20:43:24 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 344:
>> 
>>> 342:   void recycle_trash();
>>> 343:   void log_status();
>>> 344:   void log_status_under_lock();
>> 
>> Add a brief 1-line documentation comment for each of the methods, mentioning the preconditions & what they do.
>
> I forgot. Shouldn't `log_status` remove the enablement check, and assert that logging is enabled?

Discussed it in another conversation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19915#discussion_r1657900503


More information about the hotspot-gc-dev mailing list