RFR: 8326688: Parallel: Remove unnecessary BOT update in UpdateOnlyClosure::do_addr

Albert Mingkun Yang ayang at openjdk.org
Fri Mar 1 10:16:53 UTC 2024


On Fri, 1 Mar 2024 09:03:55 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Currently, BOT entries are verified on-update, the last statement of `update_for_block_work`. In my experience, they are rarely corrupted.
>
> That is my suggestion: because they are not updated any more, there will be no verification. You are right that they are rarely corrupted so that the VM crashes, but if they are not optimal, hard to detect performance issues may creep in.

`ObjectStartArray::object_start` contains assertions about BOT being precise, just fyi.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18008#discussion_r1508777968


More information about the hotspot-gc-dev mailing list