RFR: 8327477: Parallel: Remove unused ParallelCompactData::_highest_ref

Albert Mingkun Yang ayang at openjdk.org
Thu Mar 7 09:24:58 UTC 2024


On Wed, 6 Mar 2024 15:35:16 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Trivial removing dead code.
>
> src/hotspot/share/gc/parallel/psParallelCompact.hpp line 370:
> 
>> 368:     // debug builds to prevent the code fragments from breaking.
>> 369:     HeapWord*            _data_location;
>> 370: #endif  // #ifdef ASSERT
> 
> Now, we only have one field here. So the word `These` in the comment should be revised to `This`? Or the comment needs more adjustment.

Actually, `_data_location` is used only for printing, and it records the corresponding heap-addr of a region, if I read the code correctly. How about removing `_data_location` as well, given its limited value?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18139#discussion_r1515822613


More information about the hotspot-gc-dev mailing list