RFR: 8327571: Parallel: Remove redundant operation in PSParallelCompact::clear_data_covering_space

Guoxiong Li gli at openjdk.org
Thu Mar 7 13:42:55 UTC 2024


On Thu, 7 Mar 2024 12:34:19 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple removing redundant code.

Looks good.

src/hotspot/share/gc/parallel/psParallelCompact.cpp line 901:

> 899: 
> 900:   const idx_t beg_bit = _mark_bitmap.addr_to_bit(bot);
> 901:   const idx_t end_bit = _mark_bitmap.addr_to_bit(top);

The method `addr_to_bit` invokes the method `words_to_bits`, so the result is always aligned. Is my understanding right?

-------------

Marked as reviewed by gli (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18152#pullrequestreview-1922466898
PR Review Comment: https://git.openjdk.org/jdk/pull/18152#discussion_r1516172061


More information about the hotspot-gc-dev mailing list