Integrated: 8327238: Remove MetadataAllocationFailALot* develop flags
Thomas Schatzl
tschatzl at openjdk.org
Thu Mar 7 14:02:59 UTC 2024
On Wed, 6 Mar 2024 09:29:58 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> please review this trivial removal of the `MetadataFailAlot` flags; one of them,
> `MetadataAllocationFailALotInterval` is unused anyway, and the other `MetadataAllocationFailALot` only prevents the attempt to retry metadata allocation in the VM operation.
>
> This functionality does not seem to stress metadata allocation failure at all, just execution of the metadata VM operation, so I decided to just drop the second flag as well.
>
> I considered keeping it maybe as `MetadataAllocationFailRetry` or something, but decided against it since it does not seem interesting to test. However I can at reviewer's request do that.
>
> Testing: local compilation, gha, grepping hotspot tests/hotspot sources
>
> Thanks,
> Thomas
This pull request has now been integrated.
Changeset: 784f11c3
Author: Thomas Schatzl <tschatzl at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/784f11c35d7f8646c7354c756ac8801a3d685874
Stats: 12 lines in 2 files changed: 0 ins; 9 del; 3 mod
8327238: Remove MetadataAllocationFailALot* develop flags
Reviewed-by: gli, ayang
-------------
PR: https://git.openjdk.org/jdk/pull/18133
More information about the hotspot-gc-dev
mailing list