RFR: 8327452: G1: Improve scalability of Merge Log Buffers [v4]
Ivan Walulya
iwalulya at openjdk.org
Mon Mar 11 16:32:20 UTC 2024
On Mon, 11 Mar 2024 10:29:16 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove ifdef
>
> src/hotspot/share/gc/g1/g1RemSet.cpp line 1303:
>
>> 1301:
>> 1302: BufferNode* head = buffers._head;
>> 1303: BufferNode* tail = head;
>
> Because there may be non-full buffers, num_buffers may be an underestimate of
> the actual number of buffers. And buffers_per_thread is rounded down. Because
> of that, this calculation may result in various imbalances, which might be
> somewhat significant. I think it would be better to instead calculate
> (rounding up) and use entries_per_thread, and in the loop increment count by
> cur->size() (before updating cur).
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18134#discussion_r1519811504
More information about the hotspot-gc-dev
mailing list