RFR: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size [v2]

Guoxiong Li gli at openjdk.org
Fri Mar 15 05:40:43 UTC 2024


On Fri, 15 Mar 2024 05:35:23 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> When an object size meets the following three conditions, the allocation will fail unexpectedly.
>> 
>> 1. `object_size` > `uncommitted_size`
>> 2. `object_size` > `committed_but_unused_size`
>> 3. `object_size` < `unused_size` (`unused_size` equals `uncommitted_size + committed_but_unused_size`)
>> 
>> Please read the newly added test of this patch for the concrete case.
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regrads,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with 32 additional commits since the last revision:
> 
>  - Adjust test.
>  - Add assert statement.
>  - Merge branch 'master' into FAILED-ALLOCATION
>  - 8328228: Missing comma in copyright year for a few JColorChooser tests
>    
>    Reviewed-by: jpai
>  - 8328130: Remove applet usage from JColorChooser tests Test4759934
>    
>    Reviewed-by: prr
>  - 8328121: Remove applet usage from JColorChooser tests Test4759306
>    
>    Reviewed-by: azvegint
>  - 8327857: Remove applet usage from JColorChooser tests Test4222508
>    
>    Reviewed-by: prr, tr
>  - 8327859: Remove applet usage from JColorChooser tests Test4319113
>    
>    Reviewed-by: prr, tr
>  - 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
>    
>    Reviewed-by: honkar, aivanov
>  - 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program
>    
>    Reviewed-by: honkar, abhiscxk
>  - ... and 22 more: https://git.openjdk.org/jdk/compare/4e1e36d8...5c99942d

> ⚠️ @lgxbslgx This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to `Merge <project>:<branch>` where `<project>` is the name of another project in the [OpenJDK organization](https://github.com/openjdk) (for example `Merge jdk:master`).

This problem can be solved after https://github.com/openjdk/jdk/pull/18303 integrating. I shouldn't have merged the master so quickly.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18304#issuecomment-1998976748


More information about the hotspot-gc-dev mailing list