RFR: 8328112: Remove CardTable::_guard_region [v2]

Albert Mingkun Yang ayang at openjdk.org
Fri Mar 15 13:49:07 UTC 2024


On Fri, 15 Mar 2024 13:36:19 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Do you want to leave size_t num_bytes = num_cards;?

Yes. That comment is for why the conversion factor is one and the unit conversion is explicit. Otherwise, the conversion occurs as the arg is passed `compute_byte_map_size`, which can be confusing and error-prone, IMO.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18324#discussion_r1526313856


More information about the hotspot-gc-dev mailing list