RFR: 8328112: Remove CardTable::_guard_region [v3]

Guoxiong Li gli at openjdk.org
Sat Mar 16 22:18:05 UTC 2024


On Fri, 15 Mar 2024 15:42:19 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Leave var  num_bytes.
>
> src/hotspot/share/gc/shared/cardTable.cpp line 81:
> 
>> 79: 
>> 80:   // each card takes 1 byte
>> 81:   size_t num_bytes = num_cards;
> 
> Instead of the comment, actually multiplying with the number of cards with the size of a `CardValue` seems preferable:
> Suggestion:
> 
>   size_t num_bytes = num_cards * sizeof(CardValue);

Does the comment `each card takes 1 byte` need to be adjusted?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18324#discussion_r1526488188


More information about the hotspot-gc-dev mailing list