RFR: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size [v3]
Thomas Schatzl
tschatzl at openjdk.org
Mon Mar 18 11:25:29 UTC 2024
On Fri, 15 Mar 2024 13:27:13 GMT, Guoxiong Li <gli at openjdk.org> wrote:
>> Hi all,
>>
>> When an object size meets the following three conditions, the allocation will fail unexpectedly.
>>
>> 1. `object_size` > `uncommitted_size`
>> 2. `object_size` > `committed_but_unused_size`
>> 3. `object_size` < `unused_size` (`unused_size` equals `uncommitted_size + committed_but_unused_size`)
>>
>> Please read the newly added test of this patch for the concrete case.
>>
>> Thanks for taking the time to review.
>>
>> Best Regrads,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>
> - Merge branch 'master' into FAILED-ALLOCATION
>
> # Conflicts:
> # src/hotspot/share/gc/epsilon/epsilonHeap.cpp
> - Adjust test.
> - Add assert statement.
> - Merge branch 'master' into FAILED-ALLOCATION
> - JDK-8328168
> - JDK-8328166
Marked as reviewed by tschatzl (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/18304#pullrequestreview-1942678782
More information about the hotspot-gc-dev
mailing list