RFR: 8328331: Rename files 'blockOffsetTable.[h|c]pp' to 'BOTConstants.[h|c]pp'

Albert Mingkun Yang ayang at openjdk.org
Mon Mar 18 14:21:28 UTC 2024


On Mon, 18 Mar 2024 08:23:45 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This path renames the files `gc/shared/blockOffsetTable.[h|c]pp` to `BOTConstants.[h|c]pp`. Becuase these two files only have one class `BOTConstants`. Thanks for taking the time to review.
> 
> Best Regrads,
> -- Guoxiong

I feel the filename `blockOffsetTable` is more consistent with some of its collector-specific specializations, e.g. serialBlockOffsetTable, so the current filename looks fine.

The mismatch btw the filename and the class name is indeed undesirable. Looking at how this class is used, its name is used to call its static methods, so renaming it to sth longer impairs readability IMO. (The diff will be quite large as well, without much benefit.)

Maybe a simplification in this area can be removing the redundant fields of `BOTConstants` and `CardTable`?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18342#issuecomment-2004046435


More information about the hotspot-gc-dev mailing list