RFR: 8328364: Remove redundant fields in 'BOTConstants'

[Albert Mingkun Yang]

On Tue, 19 Mar 2024 05:51:51 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> The class `BOTConstants` has several redundant fields. This patch removes the redundant fields and adds a new field `CardTable::_card_shift_in_words` like `BOTConstants::_log_card_size_in_words`.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

Marked as reviewed by ayang (Reviewer).

src/hotspot/share/gc/shared/cardTable.hpp line 186:

> 184:   }
> 185: 
> 186:   static uint card_shift_in_words() {

Seems that this new API is used only for Serial and G1. I wonder if they can be changed to sth like to what Parallel does to drop the dependency on this method.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18371#pullrequestreview-1945485575
PR Review Comment: https://git.openjdk.org/jdk/pull/18371#discussion_r1529918984