RFR: 8328101: Parallel: Obsolete ParallelOldDeadWoodLimiterMean and ParallelOldDeadWoodLimiterStdDev [v2]

[Albert Mingkun Yang]

On Wed, 20 Mar 2024 09:43:52 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
>> 
>>   pgc-dead-ratio
>
> src/hotspot/share/gc/shared/gc_globals.hpp line 623:
> 
>> 621:           "value. "                                                         \
>> 622:           "Parallel full gc treats this as maximum value, i.e. a non-fully" \
>> 623:           "compact full gc cycle wastes at most this value of space. "      \
> 
> Suggestion:
> 
>           "Parallel full gc treats this as maximum value, i.e. when "       \
>           "allowing dead wood, Parallel full gc wastes at most this amount "\
>           "of space."                                                       \
> 
> I admit I did not fully understand the original description, so this is my best guess what had been meant. First, "non-fully compact full gc cycle" sounds very awkward as "non-fully" isn't defined anywhere, and what is a full gc "cycle" wrt Parallel GC?  Also s/value/amount.
> 
> Maybe also change the term "mark sweep" for Serial to "full gc" above as well because it seems to be unnecessary to refer to the algorithm here.

I meant non-"MaximumCompaction".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18278#discussion_r1531795667