Mark `allocate_new_tlab` and `unsafe_max_tlab_alloc` of `CollectedHeap` as `pure virtual`

[Stefan Karlsson]

Hi Guoxiong,

On 2024-03-21 08:22, Guoxiong Li wrote:
> Hi all,
>
> I noticed the methods `CollectedHeap::allocate_new_tlab` and
> `CollectedHeap::unsafe_max_tlab_alloc` only have the statement 
> `guarantee(false, ...)`.
> They are never run and overridden by subclasses.
> Should we mark them as `pure virtual` instead of giving an implementation?

Sounds like a good cleanup. Go for it.

Thanks,
StefanK

>
> I am going to submit a patch to change them.
> But it is good to discuss it firstly and avoid the unnecessary ticket 
> and PR.
>
> Any ideas are appreciated. Thanks.
>
>
> Best Regards,
> -- Guoxiong