RFR: 8328101: Parallel: Obsolete ParallelOldDeadWoodLimiterMean and ParallelOldDeadWoodLimiterStdDev [v3]
Stefan Johansson
sjohanss at openjdk.org
Thu Mar 21 10:05:22 UTC 2024
On Wed, 20 Mar 2024 10:05:33 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Simple refactoring Parallel full-gc dead word calculation and removing two jvm flags.
>>
>> Test: tier1-3
>
> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>
> review
I think the code change looks good. The new solution is easier to follow and better match the other GCs. But I have one question, have you done any testing to see how this changes the behavior of the Parallel Full GC for different scenarios.
To me this isn't a simple refactoring as we actually change the behavior, so I would feel much more confident approving this knowing any potential impact it would have.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18278#pullrequestreview-1951558533
More information about the hotspot-gc-dev
mailing list