RFR: 8328508: Unify the signatures of the methods address_for_index() and index_for() in BOT implementations [v2]

[Thomas Schatzl]

On Thu, 21 Mar 2024 00:40:33 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch unifies the related methods of the block offset table in Serial, Parallel and GC. It mainly removes the methods `SerialBlockOffsetSharedArray::address_for_index`, `SerialBlockOffsetSharedArray::index_for`, `G1BlockOffsetTable::address_for_index` and `G1BlockOffsetTable::index_for` and adds the corresponding methods `addr_for_entry` and `entry_for_addr`. Their usages and the signatures of other methods are also adjusted.
>> 
>> I find some duplicated code of the block offset table in Serial and Parallel (and less in G1). Maybe, we should refactor the block offset table to reduce the duplicated code in the future.
>> 
>> Tier-1 is running locally.
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Revert ObjectStartArray::block_start_reaching_into_card
>  - Drop unnecessary type conversion.

I changed the bug titles in the CRs to not do any kind of markup. Please avoid markup in bug titles. They are directly taken over into git logs, which are primarily text based, and adding markup of the day just messes with tools, and decreases readability.
Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18405#issuecomment-2017776813