RFR: 8328278: Do not print the tenuring threshold in AgeTable::print_on [v3]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Mon Mar 25 22:52:23 UTC 2024
On Sat, 23 Mar 2024 12:11:42 GMT, Guoxiong Li <gli at openjdk.org> wrote:
>> Hi all,
>>
>> This patch places the SerialGC code that computes tenuring threshold before per GC instead of after per GC, so that the method `AgeTable::print_on` prints the right tenuring threshold. Just like the current G1 implementation.
>>
>> Thanks for taking the time to review.
>>
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix test TestAgeOutput.
It looks as if you are now suppressing the tenuring threshold printing entirely? In a sense that is a crucial part of what one looks at in GC logs. May be I am missing something.
Could you share for both G1 and for Serial, the before and after logs with `+PrintTenuringDistribution` ?
-------------
PR Review: https://git.openjdk.org/jdk/pull/18329#pullrequestreview-1958928516
More information about the hotspot-gc-dev
mailing list