RFR: 8283223: gc/stringdedup/TestStringDeduplicationFullGC.java#Parallel failed with "RuntimeException: String verification failed" [v2]

[Leo Korinth]

On Mon, 25 Mar 2024 12:47:39 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> I have tried to reproduce the problem by adding load to the system but I have failed. Thomas have reproduced similar problems by adding some fairly large delays in the string deduplication service thread (https://bugs.openjdk.org/browse/JDK-8275684). In this patch I added the `systemLoad()` method and the `minMax()` method so that we can log the load when the problem appears. If the failure reappears (I can see no resent failures). We can use those methods to make the test pass on too high load.
>> 
>> `getSystemLoadAverage()` is a bit blunt and gives an average over one minute, but ought to work if we eventually would like to silence test failures on over-commissioned machines.
>> 
>> Do you think this is okay, or should I change the test to directly skip the testcase instead of adding the load log on failure, maybe that is better?
>
> Leo Korinth has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch '_master_jdk' into _8283223
>  - 8283223: gc/stringdedup/TestStringDeduplicationFullGC.java#Parallel failed with "RuntimeException: String verification failed"

Thanks Thomas and Kim!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18327#issuecomment-2019880052