RFR: 8328361: Use memset() in method CardTable::dirty_MemRegion()

Guoxiong Li gli at openjdk.org
Tue Mar 26 09:27:23 UTC 2024


On Mon, 18 Mar 2024 16:05:36 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch uses `memset` instead of explicit loop in method `CardTable::dirty_MemRegion` to simplify the code. Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Changes requested by kbarrett (Reviewer).

I notice that both `clear_MemRegion` and `clear_MemRegion` of the class `CardTable` use the method `memset`. (And many other places use `memset` too.) In my opinion, such common problem should be discussed in another issue. After coming to a conclusion, we can change all of them one time. @kimbarrett @albertnetymk what is your opinion?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18349#issuecomment-2019918062


More information about the hotspot-gc-dev mailing list