RFR: 8331208: Memory stress test that checks OutOfMemoryError stack trace fails [v2]

Doug Simon dnsimon at openjdk.org
Thu May 2 09:02:54 UTC 2024


On Thu, 2 May 2024 08:37:33 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Doug Simon has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - don't perform XX actions for OOME when in scope of an InternalOOMEMark
>>  - rename SandboxedOOMEMark to InternalOOMEMark
>
> src/hotspot/share/runtime/javaThread.hpp line 718:
> 
>> 716:   bool in_internal_oome_mark() const            { return _in_internal_oome_mark; }
>> 717:   void set_in_internal_oome_mark(bool b)        { _in_internal_oome_mark = b;    }
>> 718: 
> 
> Should all these be prefixed with `is` like:
> 
>   bool is_in_VTMS_transition() const             { return _is_in_VTMS_transition; }
>   bool is_in_tmp_VTMS_transition() const         { return _is_in_tmp_VTMS_transition; }
>   bool is_in_any_VTMS_transition() const { return _is_in_VTMS_transition || _is_in_tmp_VTMS_transition; }

Ok.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18925#discussion_r1587300112


More information about the hotspot-gc-dev mailing list